Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update XDR and core image #951

Merged
merged 1 commit into from
Sep 12, 2023
Merged

build: update XDR and core image #951

merged 1 commit into from
Sep 12, 2023

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Sep 12, 2023

What

update XDR and core image:

  • Update go monorepo to obtain latest XDR decoder.
  • Update core debian package
  • Update core docker image

Why

Sync with latest.

Known limitations

n/a

@tsachiherman tsachiherman added this to the Soroban Testnet Release milestone Sep 12, 2023
@tsachiherman tsachiherman self-assigned this Sep 12, 2023
@tsachiherman tsachiherman enabled auto-merge (squash) September 12, 2023 17:04
@tsachiherman tsachiherman merged commit 3cd84b5 into main Sep 12, 2023
@tsachiherman tsachiherman deleted the tsachi/updatecore99 branch September 12, 2023 17:44
@2opremio
Copy link
Contributor

You also need to update the rust library dependencies

@tsachiherman
Copy link
Contributor Author

You also need to update the rust library dependencies

I absolutly do. and will do it as soon as core release the sdk.

@@ -109,7 +109,7 @@ jobs:
env:
SOROBAN_RPC_INTEGRATION_TESTS_ENABLED: true
SOROBAN_RPC_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.13.1-1469.76fed6ead.focal~soroban
PROTOCOL_20_CORE_DEBIAN_PKG_VERSION: 19.13.1-1481.3acf6dd26.focal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anytime this ref to core is changed, the equivalent core git ref related to this build will be needed in e2e, i've started #952 for a draft to keep e2e up to date with current release stretch.

maybe we agree to sync up e2e in soroban-tools on a wider, less frequent iteration or once e2e is positioned more as nightly test per stellar/system-test#10, then e2e.yml can be removed from soroban-tools as part of pr-commit workflow test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a broader issue.. but it seems that some people like to make these changes manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants